RFR: 8325983: Build failure after JDK-8324580 [v2]
Daniel D. Daugherty
dcubed at openjdk.org
Thu Feb 15 21:07:55 UTC 2024
On Thu, 15 Feb 2024 17:50:49 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Zdenek Zambersky has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update comments
>
> The change looks okay. Please make sure to run the jtreg test, just to be sure.
>
> When doing a patch, try merging the master into the patch branch regularly. That can be as simple as a click on the "Sync this branch" button in Github. Then, the GHAs will re-run and in your case we'd have seen the error right away.
>
> That said, you have been unlucky because a concurrent patch that causes build errors usually also causes merge errors, which you see right away.
>
> Please wait for Daniel's okay before pushing.
@tstuefe and @zzambers - It has been more than 2 hours since I asked that this fix be
integrated. What is the hold up here? If this PR continues to just sit here, I'll start looking
at a [BACKOUT] so we can get the JDK23 CI back so that builds are executing.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17879#issuecomment-1947335483
More information about the hotspot-runtime-dev
mailing list