RFR: 8313306: More sensible reservation logging [v12]

[David Holmes]

On Thu, 15 Feb 2024 14:18:17 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> This PR implements more specialized logs for virtual memory APIs in the “os” namespace. It uses “os” and “map” as log tags using unified JVM logging as introduced in JEP 158 (https://openjdk.org/jeps/158). 
>> 
>> As far as testing is concerned, I have added a regression test to verify the logging is working accordingly.
>
> Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Making functions one lines and refactoring assert

A couple of minor nits but otherwise okay, so I will give my approval now.

Thanks.

src/hotspot/os/aix/os_aix.cpp line 1500:

> 1498:       fatal(RANGEFMT " is not a sub "
> 1499:               "range of " RANGEFMT, RANGEFMTARGS(p, s),
> 1500:               RANGEFMTARGS(addr, size));

Nit: please align parameters

src/hotspot/os/aix/os_aix.cpp line 1505:

> 1503:       fatal("range " RANGEFMT " is not aligned to pagesize (%lu)",
> 1504:                          RANGEFMTARGS(p, s),
> 1505:                          (unsigned long)pagesize);

Nit: please align parameters

src/hotspot/os/aix/os_aix.cpp line 1608:

> 1606:   shmbuf.shm_pagesize = 64*K;
> 1607:   if (shmctl(shmid, SHM_PAGESIZE, &shmbuf) != 0) {
> 1608:     ErrorPreserver ep;

The `ErrorPreserver` seems unnecessary when used with plain assertion as there is no hidden UL machinery that might unknowingly alter `errno`.

src/hotspot/os/aix/os_aix.cpp line 1612:

> 1610:                        " 64K pages) - shmctl failed. (errno=%s).",
> 1611:                        size / (64 * K),
> 1612:                        os::strerror(ep.saved_errno()));

Nit: please align parameters

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17356#pullrequestreview-1884349280
PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1491981414
PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1491981603
PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1491982576
PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1491981843