RFR: 8313306: More sensible reservation logging [v12]

Martin Doerr mdoerr at openjdk.org
Sat Feb 17 10:01:56 UTC 2024


On Thu, 15 Feb 2024 14:18:17 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> This PR implements more specialized logs for virtual memory APIs in the “os” namespace. It uses “os” and “map” as log tags using unified JVM logging as introduced in JEP 158 (https://openjdk.org/jeps/158). 
>> 
>> As far as testing is concerned, I have added a regression test to verify the logging is working accordingly.
>
> Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Making functions one lines and refactoring assert

Breaks AIX build:
os_aix.cpp:1626:5: error: unknown type name 'ErrorPreserver'; did you mean 'ErrnoPreserver'?

New test is failing on linux PPC64le:
TestMemoryAllocationLogging.java#testUncommitFailed

 exitValue = 139

java.lang.RuntimeException: Expected to get exit value of [0], exit value is: [139]
	at jdk.test.lib.process.OutputAnalyzer.shouldHaveExitValue(OutputAnalyzer.java:521)
	at TestMemoryAllocationLogging.runTestWithOptions(TestMemoryAllocationLogging.java:202)
	at TestMemoryAllocationLogging.main(TestMemoryAllocationLogging.java:195)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333)
	at java.base/java.lang.Thread.run(Thread.java:1575)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17356#issuecomment-1949921103


More information about the hotspot-runtime-dev mailing list