RFR: JDK-8325496: Make TrimNativeHeapInterval a product switch [v2]

David Holmes dholmes at openjdk.org
Sun Feb 18 22:26:55 UTC 2024


On Fri, 16 Feb 2024 07:11:04 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Looks good. Thanks. I will prepare the update for the manpage sources on Monday.
>
> Thank you @dholmes-ora !
> 
> I'll wait then for the CSR to be approved (I think Joe is still awaiting your okay there) and for a second reviewer.

Hi @tstuefe ,
I made the changes to the source markdown and regenerated the troff file and got some minor difference:

 .RE
 .TP
-\f[V]-XX:TrimNativeHeapInterval=\f[R]\f[I]millis\f[R]\f[R]
-Interval, in ms, at which the JVM will trim the native heap. Lower values
-will reclaim memory more eagerly at the cost of higher overhead. A value
-of 0 (default) disables native heap trimming.
+\f[V]-XX:TrimNativeHeapInterval=\f[R]\f[I]millis\f[R]
+Interval, in ms, at which the JVM will trim the native heap.
+Lower values will reclaim memory more eagerly at the cost of higher
+overhead.
+A value of 0 (default) disables native heap trimming.
 Native heap trimming is performed in a dedicated thread.
 .RS
 .PP

Could you adjust your PR accordingly please. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17799#issuecomment-1951463901


More information about the hotspot-runtime-dev mailing list