RFR: 8321075: RISC-V: UseSystemMemoryBarrier lacking proper OS support [v2]
Robbin Ehn
rehn at openjdk.org
Tue Feb 20 06:14:07 UTC 2024
On Tue, 20 Feb 2024 02:58:57 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed version check
>
> LGTM. Guess that's what we can do for now. I don't have a better solution either.
Thanks @RealFYang!
> src/hotspot/os/linux/systemMemoryBarrier_linux.cpp line 71:
>
>> 69: os::Linux::kernel_version(&major, &minor);
>> 70: if (!(major > 6 || (major == 6 && minor >= 9))) {
>> 71: log_info(os)("Linux kernel %ld.%ld do not support MEMBARRIER PRIVATE_EXPEDITED on RISC-V.",
>
> Suggestion: s/do/does/
Fixed
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17889#issuecomment-1953548657
PR Review Comment: https://git.openjdk.org/jdk/pull/17889#discussion_r1495288697
More information about the hotspot-runtime-dev
mailing list