RFR: JDK-8325496: Make TrimNativeHeapInterval a product switch [v4]
David Holmes
dholmes at openjdk.org
Tue Feb 20 12:05:54 UTC 2024
On Tue, 20 Feb 2024 08:16:08 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> [JDK-8293114](https://bugs.openjdk.org/browse/JDK-8293114) introduced automatic C-heap trimming, for now supported only by the glibc. It is controlled by the command line switch `TrimNativeHeapInterval`. The feature has proven very valuable to customers, and all issues have been ironed out. So, I'd like to make this switch a non-experimental product switch.
>
> Thomas Stuefe has updated the pull request incrementally with five additional commits since the last revision:
>
> - Update NativeHeapTrimmerGtest.java
> - Update TestTrimNative.java
> - Update NativeHeapTrimmerGtest.java
> - Update java.1
> - Update globals.hpp
Sorry the Oracle copyrights need a correction.
test/hotspot/jtreg/gtest/NativeHeapTrimmerGtest.java line 2:
> 1: /*
> 2: * Copyright (c) 2023, 2024 Oracle and/or its affiliates. All rights reserved.
Needs a comma after 2024
test/hotspot/jtreg/runtime/os/TestTrimNative.java line 4:
> 2: * Copyright (c) 2023 SAP SE. All rights reserved.
> 3: * Copyright (c) 2023, 2024 Red Hat, Inc. All rights reserved.
> 4: * Copyright (c) 2023, 2024 Oracle and/or its affiliates. All rights reserved.
Needs a comma after 2024
-------------
PR Review: https://git.openjdk.org/jdk/pull/17799#pullrequestreview-1890252367
PR Review Comment: https://git.openjdk.org/jdk/pull/17799#discussion_r1495703500
PR Review Comment: https://git.openjdk.org/jdk/pull/17799#discussion_r1495703718
More information about the hotspot-runtime-dev
mailing list