RFR: JDK-8326496: [test] checkHsErrFileContent support printing hserr in error case
Christoph Langer
clanger at openjdk.org
Fri Feb 23 10:49:01 UTC 2024
On Fri, 23 Feb 2024 09:22:51 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> checkHsErrFileContent checks hs error files for existance and non-existance of some user provided patterns. However it should also have an option to print the hs_err file in case of a failing check, this would make error analysis easier.
One minor remark, looks good otherwise.
test/hotspot/jtreg/runtime/ErrorHandling/HsErrFileUtils.java line 66:
> 64: * @param f Input file
> 65: * @param patterns An array of patterns that need to match, in that order
> 66: * @throws RuntimeException, {@link IOException}
The Javadoc of parameter "verbose" should not be removed here.
-------------
Marked as reviewed by clanger (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17978#pullrequestreview-1897832079
PR Review Comment: https://git.openjdk.org/jdk/pull/17978#discussion_r1500488791
More information about the hotspot-runtime-dev
mailing list