RFR: JDK-8326496: [test] checkHsErrFileContent support printing hserr in error case [v2]
Christoph Langer
clanger at openjdk.org
Fri Feb 23 11:13:54 UTC 2024
On Fri, 23 Feb 2024 11:02:07 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> test/hotspot/jtreg/runtime/ErrorHandling/HsErrFileUtils.java line 66:
>>
>>> 64: * @param f Input file
>>> 65: * @param patterns An array of patterns that need to match, in that order
>>> 66: * @throws RuntimeException, {@link IOException}
>>
>> The Javadoc of parameter "verbose" should not be removed here.
>
> okay I added it again; but it was already not documented in the same way before my change, once "the matched patterns are printed" once "only important information are printed" . Should we adjust it and to what ?
Looking at what "verbose" does, I'd say the correct description would be "only the matched patterns are printed"
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17978#discussion_r1500517614
More information about the hotspot-runtime-dev
mailing list