RFR: JDK-8326586: Improve Speed of System.map

[Stefan Karlsson]

On Mon, 26 Feb 2024 08:03:14 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> src/hotspot/share/nmt/memMapPrinter.cpp line 134:
>> 
>>> 132:     // of OS mappings is scanned (VirtualQuery, /proc/pid/maps), and these lists
>>> 133:     // are usually sorted in order of addresses, ascending.
>>> 134:     static uintx last = 0;
>> 
>> Sorry, I should've caught this when we first reviewed this, but why are we using `uintx` instead of `uintptr_t`?
>
> Technically these are the same. I tend to prefer `uintx` when its indexes, not addresses, they designate. As in "things you count" vs "things you point to".

In other parts of HotSpot we have been changed usages of `uintx` to instead use `size_t`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17984#discussion_r1502673557