RFR: JDK-8322943: runtime/CompressedOops/CompressedClassPointers.java fails on AIX [v2]
Goetz Lindenmaier
goetz at openjdk.org
Mon Feb 26 15:42:45 UTC 2024
On Wed, 14 Feb 2024 16:45:05 GMT, Joachim Kern <jkern at openjdk.org> wrote:
>> Even after recent fixes like
>> https://bugs.openjdk.org/browse/JDK-8305765
>> the test runtime/CompressedOops/CompressedClassPointers.java fails on AIX.
>>
>> This error results from the fact, that on AIX the shmat() allocation granularity is 256MB instead of the standard Pagesize (4KB or 64KB).
>>
>> As a solution we introduce a new method `os::vm_shm_allocation_granularity()`, which on all platforms except AIX returns the same value as `os::vm_allocation_granularity()`, but on AIX it returns (in the apropriate cases) 256MB.
>>
>> This new getter is used at all needed places instead of `os::vm_allocation_granularity()`.
>
> Joachim Kern has updated the pull request incrementally with one additional commit since the last revision:
>
> following Goetz objections
I don't think a local test fix makes sense. After all it is a real issue that os::attempt_reserve_memory_between() is using 4K alignment when we try to allocate 256M shmat memory.
We could do a temporary #ifdef AIX solution in that function.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17708#issuecomment-1964446586
More information about the hotspot-runtime-dev
mailing list