RFR: JDK-8326496: [test] checkHsErrFileContent support printing hserr in error case [v3]

[Matthias Baesken]

On Fri, 23 Feb 2024 12:37:06 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> checkHsErrFileContent checks hs error files for existance and non-existance of some user provided patterns. However it should also have an option to print the hs_err file in case of a failing check, this would make error analysis easier.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adjust doc of verbose param

Hi David,

>why does that not suffice? 
>And if it doesn't suffice why don't you just grab the hs_err file from the test artifacts and examine it directly?

For the forbidden patterns it might indeed suffice (however having more information understanding the context of why a forbidden pattern occurs is still often necessary).
On some shielded containers / Jenkins setups I usually only have the log and cannot 'collect' additional information.  This is not the exception but a very common thing.
(In my local environment I do not see the error , so no hserr is printed)
Btw. we are totally fine with a _verbose_ parameter of the check function (prints the hserr content even in case of success) .

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17978#issuecomment-1968540718