RFR: JDK-8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output

[David Holmes]

On Tue, 2 Jan 2024 14:44:30 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Currently, /etc/SuSE-release is prioritized over /etc/os-release in the hs_info/hs_err file output .
> But this leads on SUSE 12 distros to output like this :
> 
> 
> # This file is deprecated and will be removed in a future service pack or release.
> # Please check /etc/os-release for details about this release.
> 
> 
> So we probably better prioritize /etc/os-release over /etc/SuSE-release.

As long as older versions we care about are guaranteed to have a valid os-release file then this seems fine.

One suggested comment below.

Thanks

src/hotspot/os/linux/os_linux.cpp line 2107:

> 2105:   "/etc/system-release",
> 2106:   "/etc/os-release",
> 2107:   "/etc/SuSE-release",

Suggestion:

"/etc/SuSE-release",    // Deprecated in favor of os-release since SuSE 12

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17222#pullrequestreview-1801295839
PR Review Comment: https://git.openjdk.org/jdk/pull/17222#discussion_r1440012945