RFR: 8322853: Should use ConditionalMutexLocker in NativeHeapTrimmerThread::print_state [v2]

Aleksey Shipilev shade at openjdk.org
Wed Jan 3 11:38:48 UTC 2024


On Wed, 3 Jan 2024 07:06:57 GMT, Denghui Dong <ddong at openjdk.org> wrote:

>> Hi all,
>> 
>> Please help review this small fix.
>> 
>> MutexLocker requires that mutex != nullptr, so we should use ConditionalMutexLocker instead.
>> 
>> ~~Also, this patch made '_stop' volatile, since it will be read twice in run() but may be changed.~~
>
> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update

Looks fine.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17226#pullrequestreview-1801831905


More information about the hotspot-runtime-dev mailing list