RFR: 8313083: Print 'rss' and 'cache' as part of the container information

Severin Gehwolf sgehwolf at openjdk.org
Mon Jan 8 15:54:26 UTC 2024


On Tue, 19 Dec 2023 17:41:51 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

> We add "rss" and "cache" metrics to cgroups v1 and v2
> 
> For cgroups v1, those metrics are named accordingly and are retrieved using the same names.
> 
> For cgroups v2, those metrics seem not to be directly provided, but instead we need:
> - `"anon"` for "rss"
> - `"file"` for "cache"
> 
> The cgroups v2 docs do not actually state this equivalence (https://docs.kernel.org/admin-guide/cgroup-v2.html), but instead this comes from reading cAdvisor src code - https://github.com/google/cadvisor/blob/2129e1c4fae8567551d1ac252c7a1dec27617e21/container/libcontainer/handler.go#L814C4-L814C4

This seems good. Please add a test for the new `rss_usage_in_bytes` and `cache_usage_in_bytes` output in `test/hotspot/jtreg/containers/docker/TestMisc.java`. Thanks!

-------------

PR Review: https://git.openjdk.org/jdk/pull/17161#pullrequestreview-1809444009


More information about the hotspot-runtime-dev mailing list