RFR: 8322657: CDS filemap fastdebug assert while loading Graal CE Polyglot in isolated classloader [v2]

[Calvin Cheung]

On Mon, 8 Jan 2024 22:11:38 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - comment from Matias
>>  - Merge branch 'master' of github.com:openjdk/jdk into 8322657-filemap-assert
>>  - 8322657: CDS filemap fastdebug assert while loading Graal CE Polyglot in isolated classloader
>
> test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/test-classes/DefineModuleApp.java line 39:
> 
>> 37:     public static void main(String[] args) throws Throwable {
>> 38:         if (args.length != 2) {
>> 39:             throw new RuntimeException("DefineModuleApp expects 2 args but saw only " + args.length);
> 
> Minor nit: "only" is probably unnecessary in the exception message since you could technically pass more than 2 args.

Thanks. I've removed the "only" in the exception message.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17275#discussion_r1445455170