RFR: 8313083: Print 'rss' and 'cache' as part of the container information [v3]

Severin Gehwolf sgehwolf at openjdk.org
Tue Jan 9 09:32:23 UTC 2024


On Mon, 8 Jan 2024 21:54:44 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> We add "rss" and "cache" metrics to cgroups v1 and v2
>> 
>> For cgroups v1, those metrics are named accordingly and are retrieved using the same names.
>> 
>> For cgroups v2, those metrics seem not to be directly provided, but instead we need:
>> - `"anon"` for "rss"
>> - `"file"` for "cache"
>> 
>> The cgroups v2 docs do not actually state this equivalence (https://docs.kernel.org/admin-guide/cgroup-v2.html), but instead this comes from reading cAdvisor src code - https://github.com/google/cadvisor/blob/2129e1c4fae8567551d1ac252c7a1dec27617e21/container/libcontainer/handler.go#L814C4-L814C4
>
> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix tabs

LGTM

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17161#pullrequestreview-1810743032


More information about the hotspot-runtime-dev mailing list