RFR: 8314186: runtime/8176717/TestInheritFD.java failed with "Log file was leaked"

[Leo Korinth]

On Tue, 9 Jan 2024 14:50:06 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi,
>> 
>> This PR intends to make the test a bit more sturdy by looking for both the success string and the failure string, reporting that the test messed up if neither are found. I also removed the extra newline at the end of the file and did some special reporting in case of a `TimeoutException`.
>> 
>> Thanks!
>
> test/hotspot/jtreg/runtime/8176717/TestInheritFD.java line 258:
> 
>> 256:             throw new RuntimeException("Log file was leaked to the third VM.");
>> 257:         } else {
>> 258:             throw new RuntimeException("Found neither message, I am confused!");
> 
> I need some help here, should this really throw? I assume that that makes the test fail, and maybe that's not actually what we want?

I think a fail is all right as long as we can distinguish between the cases.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17325#discussion_r1446445763