RFR: 8314186: runtime/8176717/TestInheritFD.java failed with "Log file was leaked"
David Holmes
dholmes at openjdk.org
Wed Jan 10 06:12:23 UTC 2024
On Tue, 9 Jan 2024 18:57:17 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:
>> I need to look at it a bit more, I think this is not correct.
>
> The original code seems to try to catch one of two runtime exceptions: CancellationException or CompletionException. The code you added can not be correct as a TimeoutException is a checked exception (and not thrown if I understand the code correctly).
I agree with Leo. IIUC if we timeout then a `CompletionException` will be thrown from `join()` with `TimeoutException` as the cause.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17325#discussion_r1446925055
More information about the hotspot-runtime-dev
mailing list