RFR: 8314186: runtime/8176717/TestInheritFD.java failed with "Log file was leaked" [v2]

[David Holmes]

On Wed, 10 Jan 2024 16:45:08 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> I understood it as Johan wanted the exception to be reported as an "Error" instead of a "Fail" to show that the testcase is bad and not (necessarily) the JVM.
>
> Yes, what Leo said. Some way of signalling to the CI/CD system that it's the test that didn't function correctly, not that the test found an issue. Seems like that doesn't exist, so differentiating the two cases with a log line is good enough.

If the test terminates by throwing an exception then the test failed. We often have cases in a test where we should not reach and it is normal to place a throw there in case we ever do - similar to VM `ShouldNotReachHere()`. The fact it may indicate a test issue rather than a VM issue does not matter. Comments in "log" lines don't help because they rarely get read.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17325#discussion_r1448291217