RFR: 8323576: [Windows] Fallthrough to std::abort instead of os::infinite_sleep for noreturn methods

Julian Waters jwaters at openjdk.org
Thu Jan 11 08:35:40 UTC 2024


os::infinite_sleep should only be used in very specific scenarios, and using it to satisfy compiler requirements for [[noreturn]] marked methods is a bad idea, since in the impossible case this will cause HotSpot to hang for a seemingly unknown reason. Fallthrough to std::abort instead, like other platforms do, to align Windows with them

-------------

Commit messages:
 - std::abort in vmError_windows.cpp
 - 8323576

Changes: https://git.openjdk.org/jdk/pull/17366/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17366&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8323576
  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/17366.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17366/head:pull/17366

PR: https://git.openjdk.org/jdk/pull/17366


More information about the hotspot-runtime-dev mailing list