RFR: 8323243: JNI invocation of an abstract instance method corrupts the stack [v3]
David Holmes
dholmes at openjdk.org
Fri Jan 12 00:57:44 UTC 2024
On Thu, 11 Jan 2024 08:47:22 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Added direct Java test per Aleksey's request
>
> This looks good.
>
> Minor nit still: I think we gotta try the Java side first, because that checks the expected behavior. Right now, if JNI fails, we don't really know if that is a product bug (= "JNI failed to throw AME when it should"), or a test bug (= "the way the test is written, even plain Java does not throw AME"). The point of positive test is to verify the test does what it should: if Java test passes and JNI fails, there is a clear indication JNI does something wrong.
>
> Can we also say "Did not get AbstractMethodError from JNI!" and "Did not get AbstractMethodError from Java!" in exception messages, so that it would be abundantly clear which test had failed.
@shipilev Test updated as suggested.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17337#issuecomment-1888218839
More information about the hotspot-runtime-dev
mailing list