RFR: 8300088: [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE [v2]

[Gerard Ziemski]

On Fri, 12 Jan 2024 06:14:37 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Revised structure looks good. Just some minor suggestions. Thanks.

Thank you for more feedback.

> src/hotspot/os/bsd/os_bsd.cpp line 2042:
> 
>> 2040:       log_info(os)("os::init_2 getrlimit failed: %s", os::strerror(errno));
>> 2041:     } else {
>> 2042:       rlim_t rlim_org = nbr_files.rlim_cur;
> 
> Nit: can you use `rlim_orig` instead of `rlim_org` please.

I always struggle with how to shorten variable names. I guess when I need to shorten a word, I try to stay at 3 letters (original DOS extension limit?)

What if I simply use "rlim_original"?

It's only used one time and the code line where it's used is short enough to fit it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17361#issuecomment-1889884027
PR Review Comment: https://git.openjdk.org/jdk/pull/17361#discussion_r1450879724