RFR: 8323576: [Windows] Fallthrough to std::abort instead of os::infinite_sleep for noreturn methods

David Holmes dholmes at openjdk.org
Mon Jan 15 07:41:20 UTC 2024


On Mon, 15 Jan 2024 05:37:00 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> I believe ShouldNotReachHere ultimately calls back into the code in question here

I don't think it does. This code underpins `os::exit` while `ShouldNotReachHere` should lead to an abort.

But okay to have windows call `::abort` like other platforms, just not `std::abort`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17366#issuecomment-1891477103


More information about the hotspot-runtime-dev mailing list