RFR: 8323576: [Windows] Fallthrough to ::abort instead of os::infinite_sleep for noreturn methods [v2]

Julian Waters jwaters at openjdk.org
Tue Jan 16 06:22:45 UTC 2024


> os::infinite_sleep should only be used in very specific scenarios, and using it to satisfy compiler requirements for [[noreturn]] marked methods is a bad idea, since in the impossible case this will cause HotSpot to hang for a seemingly unknown reason. Fallthrough to ::abort instead, like other platforms do, to align Windows with them

Julian Waters has updated the pull request incrementally with two additional commits since the last revision:

 - std::abort to ::abort in vmError_windows.cpp
 - std::_Exit to ::_Exit in os_windows.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17366/files
  - new: https://git.openjdk.org/jdk/pull/17366/files/5b6e0d36..8d39730e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17366&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17366&range=00-01

  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/17366.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17366/head:pull/17366

PR: https://git.openjdk.org/jdk/pull/17366


More information about the hotspot-runtime-dev mailing list