RFR: 8324041: ModuleOption.java failed with update release versioning scheme

David Holmes dholmes at openjdk.org
Fri Jan 19 02:51:26 UTC 2024


On Wed, 17 Jan 2024 23:49:05 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> A small adjustment to the `ModuleOption.java` test to handle update release versioning scheme.
> 
> Manually tested with JDK 22.0.1 and 23 internal builds.

The fix seems okay, though I'm not clear exactly what the test is checking for. It would be useful is the test contained an example of the expected line(s) it wants to match. 

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17473#pullrequestreview-1831164104


More information about the hotspot-runtime-dev mailing list