RFR: 8323438: Enhance assertions for Windows sync API failures

[Calvin Cheung]

On Wed, 17 Jan 2024 01:20:32 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Using the assertion pattern employed in windows_semaphore.cpp, the other (inadequately checked) calls to WaitForSingleObject are checked more thoroughly so that the actual failure mode is reported.
> 
> The only tricky part of these changes is a change to the if/else control flow so that the result of the call can be checked, in one section. Otherwise we just expand existing assertions or guarantees.
> 
> Testing: Windows tiers 1-4 sanity
> 
> Thanks

Looks good. Just couple of nits:

- for clarity, should `GetLastError()` be `::GetLastError()`? (I saw both ways in the existing code)
- copyright year needs to be updated.

-------------

Marked as reviewed by ccheung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17457#pullrequestreview-1831624443