RFR: 8323576: [Windows] Fallthrough to ::abort instead of os::infinite_sleep for noreturn methods [v2]

Julian Waters jwaters at openjdk.org
Fri Jan 19 12:12:25 UTC 2024


On Fri, 19 Jan 2024 02:25:20 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ah, I was thinking the standard C method could be preferred over the Microsoft deprecated _exit method, but I guess that's out of scope. I'm currently working on some build dev issue, I'll change this back later on
>
> Okay. The `_Exit` is the ISO C function, but POSIX also defines `_exit` (not that that is relevant to Windows). I can't see anything saying that Microsoft have deprecated `_exit` though:
> https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/exit-exit-exit?view=msvc-170
> If we were to change this I would still want the `ALLOW_C_FUNCTION`. Thanks

I guess I can leave that _Exit change for another day, it wouldn't make sense to have ALLOW_C_FUNCTION on something that is not banned by HotSpot after all

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17366#discussion_r1458903839


More information about the hotspot-runtime-dev mailing list