RFR: 8300088: [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE [v3]

[Gerard Ziemski]

On Thu, 18 Jan 2024 22:01:19 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   David's feedback
>
> src/hotspot/os/bsd/os_bsd.cpp line 2044:
> 
>> 2042:       rlim_t rlim_original = nbr_files.rlim_cur;
>> 2043: 
>> 2044:       // on macOS according to setrlimit(2), OPEN_MAX must be used instead
> 
> Nit typo: s/on macOS/On macOS/

That was deliberate, I tried to keep the same capitalization scheme as the other immediate code around this change and since they use small letters.

However, looking at the larger picture of the code around it, it appears that the rest capitalizes the comments.

I will switch it.

> src/hotspot/os/bsd/os_bsd.cpp line 2056:
> 
>> 2054:       status = setrlimit(RLIMIT_NOFILE, &nbr_files);
>> 2055:       if (status != 0) {
>> 2056:         // if that fails then try lowering the limit to either OPEN_MAX
> 
> nit typo: s/if that/If that/

I will fix it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17361#discussion_r1459256879
PR Review Comment: https://git.openjdk.org/jdk/pull/17361#discussion_r1459257162