RFR: 8323556: CDS archive space addresses should be randomized with ArchiveRelocationMode=1 [v2]

[Matias Saavedra Silva]

On Wed, 17 Jan 2024 17:23:07 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Please review this small fix for ensuring the reserved archive space addresses are different from run to run. The bug is only on the aarch64 platforms. The fix is to call `os::init_random()` if aslr is `true` and not dumping CDS static archive.
>> 
>> Tested manually on linux-aarch64 and macosx-aarch64 platforms.
>> 
>> % ./jdk-23/fastdebug/bin/java -Xlog:cds --version | grep archive_space_rs | tail -1
>> [0.015s][info][cds] Reserved archive_space_rs [0x0000200000000000 - 0x0000200001000000] (16777216) bytes
>> % ./jdk-23/fastdebug/bin/java -Xlog:cds --version | grep archive_space_rs | tail -1
>> [0.014s][info][cds] Reserved archive_space_rs [0x0000080000000000 - 0x0000080001000000] (16777216) bytes
>> 
>> The fix also passed tiers 1 - 4 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @iklam comments

I had a similar concern as Ioi about the call to os::random() but the most recent commit seems to fix this. LGTM!

-------------

Marked as reviewed by matsaave (Committer).

PR Review: https://git.openjdk.org/jdk/pull/17409#pullrequestreview-1833255722