RFR: 8324041: ModuleOption.java failed with update release versioning scheme [v2]

Calvin Cheung ccheung at openjdk.org
Fri Jan 19 17:05:38 UTC 2024


On Fri, 19 Jan 2024 02:48:39 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add comment
>
> The fix seems okay, though I'm not clear exactly what the test is checking for. It would be useful is the test contained an example of the expected line(s) it wants to match. 
> 
> Thanks

Thanks @dholmes-ora @MBaesken for the reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17473#issuecomment-1900771385


More information about the hotspot-runtime-dev mailing list