RFR: 8323576: [Windows] Fallthrough to ::abort instead of os::infinite_sleep for noreturn methods [v3]

Julian Waters jwaters at openjdk.org
Sun Jan 21 07:15:49 UTC 2024


> os::infinite_sleep should only be used in very specific scenarios, and using it to satisfy compiler requirements for [[noreturn]] marked methods is a bad idea, since in the impossible case this will cause HotSpot to hang for a seemingly unknown reason. Fallthrough to ::abort instead, like other platforms do, to align Windows with them

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Partially revery os_windows.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17366/files
  - new: https://git.openjdk.org/jdk/pull/17366/files/8d39730e..abce4718

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17366&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17366&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17366.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17366/head:pull/17366

PR: https://git.openjdk.org/jdk/pull/17366


More information about the hotspot-runtime-dev mailing list