RFR: 8323438: Enhance assertions for Windows sync API failures [v2]

David Holmes dholmes at openjdk.org
Mon Jan 22 04:16:50 UTC 2024


> Using the assertion pattern employed in windows_semaphore.cpp, the other (inadequately checked) calls to WaitForSingleObject are checked more thoroughly so that the actual failure mode is reported.
> 
> The only tricky part of these changes is a change to the if/else control flow so that the result of the call can be checked, in one section. Otherwise we just expand existing assertions or guarantees.
> 
> Testing: Windows tiers 1-4 sanity
> 
> Thanks

David Holmes has updated the pull request incrementally with one additional commit since the last revision:

  Fix copyright

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17457/files
  - new: https://git.openjdk.org/jdk/pull/17457/files/95c92091..94d2c3a9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17457&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17457&range=00-01

  Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/17457.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17457/head:pull/17457

PR: https://git.openjdk.org/jdk/pull/17457


More information about the hotspot-runtime-dev mailing list