RFR: 8323438: Enhance assertions for Windows sync API failures [v2]

[Julian Waters]

On Mon, 22 Jan 2024 04:16:50 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Using the assertion pattern employed in windows_semaphore.cpp, the other (inadequately checked) calls to WaitForSingleObject are checked more thoroughly so that the actual failure mode is reported.
>> 
>> The only tricky part of these changes is a change to the if/else control flow so that the result of the call can be checked, in one section. Otherwise we just expand existing assertions or guarantees.
>> 
>> Testing: Windows tiers 1-4 sanity
>> 
>> Thanks
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix copyright

Not that it means much since this is coming from me, but given this is an easy to review change and is in Windows code I figured why not. Have a +1, especially for the proper %lu format specifiers :)

-------------

Marked as reviewed by jwaters (Committer).

PR Review: https://git.openjdk.org/jdk/pull/17457#pullrequestreview-1835901897