RFR: 8300088: [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE [v5]

[David Holmes]

On Mon, 22 Jan 2024 17:49:42 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> On current macOS (> 10.6) we can use `RLIM_INFINITY` for `setrlimit(RLIMIT_NOFILE)`, even though the man page for setrlimit(2) claims otherwise.
>> 
>> The only wrinkle here is that some terminals (ksh) will crash with `RLIM_INFINITY`, because that value overflows `int` type, which they use internally, causing crash, so we work around that by using `INT_MAX` instead of `RLIM_INFINITY`.
>
> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix capitalization issue in comments around this fix

Okay.

src/hotspot/os/bsd/os_bsd.cpp line 1997:

> 1995:   Bsd::initialize_system_info();
> 1996: 
> 1997:   // _main_thread points to the thread that created/loaded the JVM

If the "sentence" starts with a variable name then you can't capitalize it, so this could have stayed as it was, but is also fine without the period.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17361#pullrequestreview-1837549141
PR Review Comment: https://git.openjdk.org/jdk/pull/17361#discussion_r1462524775