Integrated: 8323438: Enhance assertions for Windows sync API failures

David Holmes dholmes at openjdk.org
Tue Jan 23 01:12:36 UTC 2024


On Wed, 17 Jan 2024 01:20:32 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Using the assertion pattern employed in windows_semaphore.cpp, the other (inadequately checked) calls to WaitForSingleObject are checked more thoroughly so that the actual failure mode is reported.
> 
> The only tricky part of these changes is a change to the if/else control flow so that the result of the call can be checked, in one section. Otherwise we just expand existing assertions or guarantees.
> 
> Testing: Windows tiers 1-4 sanity
> 
> Thanks

This pull request has now been integrated.

Changeset: 5a74c2a6
Author:    David Holmes <dholmes at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5a74c2a67ebcb47e51732f03c4be694bdf920469
Stats:     36 lines in 3 files changed: 21 ins; 1 del; 14 mod

8323438: Enhance assertions for Windows sync API failures

Reviewed-by: ccheung, jwaters, dcubed

-------------

PR: https://git.openjdk.org/jdk/pull/17457


More information about the hotspot-runtime-dev mailing list