RFR: 8324514: ClassLoaderData::print_on should print address of class loader [v3]

[Coleen Phillimore]

On Tue, 23 Jan 2024 13:56:21 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   peek_raw
>
> src/hotspot/share/classfile/classLoaderData.cpp line 1006:
> 
>> 1004:     out->print_cr("");
>> 1005:   }
>> 1006:   out->print_cr(" - class loader        " INTPTR_FORMAT, p2i(_class_loader.peek_raw()));
> 
> This peek_raw feels like a dangerous addition. Could be misused(?)  @kimbarrett has been looking at OopHandle, maybe he has an opinion.  I can't remember why/whether we can't do a peek on an unloaded class loader. Also @fisk is the definitive source of this info (plus you guys on Shenandoah too).

Yes, I suppose we did want to print the oop not the OopHandle pointer.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17534#discussion_r1463339483