RFR: 8300088: [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE [v5]

Gerard Ziemski gziemski at openjdk.org
Tue Jan 23 16:13:35 UTC 2024


On Mon, 22 Jan 2024 23:01:03 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix capitalization issue in comments around this fix
>
> src/hotspot/os/bsd/os_bsd.cpp line 1997:
> 
>> 1995:   Bsd::initialize_system_info();
>> 1996: 
>> 1997:   // _main_thread points to the thread that created/loaded the JVM
> 
> If the "sentence" starts with a variable name then you can't capitalize it, so this could have stayed as it was, but is also fine without the period.

I treated non-multiline comment as in-line comment, without the need for capitalization and period. I was trying to have some consistency.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17361#discussion_r1463533305


More information about the hotspot-runtime-dev mailing list