RFR: 8300088: [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE [v5]
Gerard Ziemski
gziemski at openjdk.org
Tue Jan 23 16:18:41 UTC 2024
On Mon, 22 Jan 2024 17:49:42 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
>> On current macOS (> 10.6) we can use `RLIM_INFINITY` for `setrlimit(RLIMIT_NOFILE)`, even though the man page for setrlimit(2) claims otherwise.
>>
>> The only wrinkle here is that some terminals (ksh) will crash with `RLIM_INFINITY`, because that value overflows `int` type, which they use internally, causing crash, so we work around that by using `INT_MAX` instead of `RLIM_INFINITY`.
>
> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>
> fix capitalization issue in comments around this fix
Thank you very much for the feedback!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17361#issuecomment-1906405422
More information about the hotspot-runtime-dev
mailing list