Integrated: 8324514: ClassLoaderData::print_on should print address of class loader
Aleksey Shipilev
shade at openjdk.org
Wed Jan 24 17:42:38 UTC 2024
On Tue, 23 Jan 2024 11:50:24 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> This looks like a simple diagnostic regression from [JDK-8201556](https://bugs.openjdk.org/browse/JDK-8201556). Instead of printing the address of the `OopHandle` slot, we really want to print the address of the classloader that handle holds. That was not intentional, right, @coleenp?
>
> I think we can `peek()` into handle, but the whole reason for [JDK-8201556](https://bugs.openjdk.org/browse/JDK-8201556) seems to avoid touching the classloader oops when unloading, and `peek()` would do a GC barrier on it. We could specialize for `!unloading` path, but I think we still want to see what is in the handle. So, this PR introduces the "peek_raw" version that would compile straight to plain access, after the null check.
This pull request has now been integrated.
Changeset: fb822e49
Author: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/fb822e49f2a84423c8fd17db2e95bbdd5e7ec191
Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
8324514: ClassLoaderData::print_on should print address of class loader
Reviewed-by: kbarrett, coleenp
-------------
PR: https://git.openjdk.org/jdk/pull/17534
More information about the hotspot-runtime-dev
mailing list