RFR: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
Fei Yang
fyang at openjdk.org
Wed Jan 24 23:54:37 UTC 2024
On Mon, 22 Jan 2024 08:39:28 GMT, MaxXing <duke at openjdk.org> wrote:
> Currently, method `VM_Version::os_uarch_additional_features` uses `fgets` to read the contents of `/proc/cpuinfo`, then calls `parse_satp_mode` with a string with the leading "mmu" and whitespaces removed, like ": sv39\n". However, `parse_satp_mode` compares this string directly to "sv39", which always fails and returns `VM_MBARE`.
Marked as reviewed by fyang (Reviewer).
Verified that this happens after fix for: https://bugs.openjdk.org/browse/JDK-8309258. Note: @robehn
-------------
PR Review: https://git.openjdk.org/jdk/pull/17513#pullrequestreview-1838509144
PR Comment: https://git.openjdk.org/jdk/pull/17513#issuecomment-1905243493
More information about the hotspot-runtime-dev
mailing list