RFR: 8323994: gtest runner repeats test name for every single gtest assertion [v2]

Sonia Zaldana Calles szaldana at openjdk.org
Thu Jan 25 14:20:59 UTC 2024


On Wed, 24 Jan 2024 22:41:24 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing copyright header and spacing issue
>
> test/hotspot/jtreg/gtest/GTestResultParser.java line 61:
> 
>> 59:                         case "failure":
>> 60:                             String failedStr = testSuite + "::" + testCase;
>> 61:                             if (! failedTests.contains(failedStr)) {
> 
> Please remove space between '! and failed..'.

Thanks @lmesnik! I pushed the changes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17489#discussion_r1466442558


More information about the hotspot-runtime-dev mailing list