RFR: 8321931: memory_swap_current_in_bytes reports 0 as "unlimited" [v7]
Gerard Ziemski
gziemski at openjdk.org
Sat Jan 27 02:39:45 UTC 2024
On Thu, 25 Jan 2024 16:57:34 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> Gerard Ziemski has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - whitespace
>> - fix how we check
>
> test/hotspot/jtreg/containers/docker/TestContainerInfo.java line 83:
>
>> 81: if (s.contains("memory_swap_max_limit_in_bytes")) {
>> 82: if (!s.contains("0")) {
>> 83: throw new RuntimeException("memory_swap_max_limit_in_bytes NOT 0!");
>
> Suggestion: `throw new RuntimeException("memory_swap_max_limit_in_bytes NOT 0! Line was: " + s);`
done
> test/hotspot/jtreg/containers/docker/TestContainerInfo.java line 93:
>
>> 91: throw new RuntimeException("memory_swap_current_in_bytes NOT 0!");
>> 92: }
>> 93: if (s.contains("Unlimited")) {
>
> It's actually lower case `unlimited`.
done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17314#discussion_r1468282748
PR Review Comment: https://git.openjdk.org/jdk/pull/17314#discussion_r1468282737
More information about the hotspot-runtime-dev
mailing list