RFR: 8324126: Error message for mistyping -XX:+Unlock...Options is not helpful

[David Holmes]

On Fri, 26 Jan 2024 05:59:26 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> I think this is fine, and a minor concern, but let's ask @dholmes-ora.

So existing logic gives preference to whether the flag is unlocked, and then examines whether it is well-formed. The new code gives preference to whether it is well-formed and then whether it is unlocked. Can't you do both together?

> The alternative would be to not make "UseDiagnosticVMOptions" option itself diagnostic, and vice versa with UseExperimentalVMOptions. Wonder what the reason for that was, @dholmes-ora ?

I expect because it was considered appropriate. If those flags were themselves product flags then they would be subject to product flag rules.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17575#issuecomment-1913877854