RFR: 8321931: memory_swap_current_in_bytes reports 0 as "unlimited" [v8]
Ioi Lam
iklam at openjdk.org
Mon Jan 29 12:37:33 UTC 2024
On Tue, 16 Jan 2024 18:13:06 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>>
>> jerboaa feedback
>
> src/hotspot/os/linux/osContainer_linux.hpp line 48:
>
>> 46: static void init();
>> 47: static void print_version_specific_info(outputStream* st);
>> 48: static void print_container_helper(outputStream* st, jlong j, const char* metrics, boolean limit = false);
>
> Can we name this parameter better, or add a comment at least?
Maybe `boolean zero_means_unlimited = false`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17314#discussion_r1453835320
More information about the hotspot-runtime-dev
mailing list