RFR: 8313306: More sensible reservation logging [v2]

[Sonia Zaldana Calles]

On Mon, 29 Jan 2024 02:06:51 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Sonia Zaldana Calles has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Implementation of high level debug logging and low level trace logging
>>  - Implementation of high level debug logging
>>  - Feedback - deleting oracle copyright and fixing INTPTR formatting
>
> src/hotspot/os/aix/os_aix.cpp line 301:
> 
>> 299:       ErrnoPreserver ep;
>> 300:       log_trace(os,map)("Cannot disclaim %p - %p (errno %d)\n", p, p + maxDisclaimSize, errno);
>> 301:       trcVerbose("Cannot disclaim %p - %p (errno %d)\n", p, p + maxDisclaimSize, errno);
> 
> I don't think you need actual unified logging and the crude `trcVerbose`, but perhaps that would be a separate cleanup. Though the duplication is pretty awful.

Hi @dholmes-ora, just a follow up question on this point. 

What do you think would be the best course of action for the time being?

Leave the duplication and then open another issue to handle the ```trcVerbose``` cleanup or remove the unified logging from this PR altogether?

Thanks for taking a look!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1469976971