RFR: 8324838: test_nmt_locationprinting.cpp broken in the gcc windows build
David Holmes
dholmes at openjdk.org
Tue Jan 30 07:22:41 UTC 2024
On Mon, 29 Jan 2024 12:52:11 GMT, Julian Waters <jwaters at openjdk.org> wrote:
> test_nmt_locationprinting.cpp defines method test_for_dead_c_heap_block unconditionally, but this method is only ever used on Linux. In the gcc windows build this fires an unused method warning and breaks the gtest suite. Since this is never used outside of Linux, make this method's definition only appear on Linux to avoid polluting code on other platforms
Seems reasonable given the other use of `ifdef LINUX` around the actual calls.
Please change the Oracle copyright year to read `2023, 2024,`. Thanks
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17612#pullrequestreview-1850383798
More information about the hotspot-runtime-dev
mailing list