RFR: 8313306: More sensible reservation logging [v2]

Thomas Stuefe stuefe at openjdk.org
Tue Jan 30 10:39:41 UTC 2024


On Mon, 29 Jan 2024 02:19:04 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Also isn't the whole point of using the preserver to allow you capture errno and read it back from the preserver without caring if something in the logging code changed it in the meantime?
>
> i.e rather than passing `errno` as a parameter, you should be passing `ep.errno()`

> crude approach of trcVerbose

Opinions differ, obviously, since these trace lines are from me originally. Not sure what's crude about them.

I don't care much one way or the other, but just to defend my original code: 
- errno numerical are short, concise and well defined within their OS. 
- their enum counterparts (EINVAL etc) are too
- strerror is not as clear and, most annoyingly, localization-dependent. A german customer running the JVM with a german locale will see (and give to your support people) logs containing german error messages.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1470957786


More information about the hotspot-runtime-dev mailing list