RFR: 8313306: More sensible reservation logging [v2]

[Thomas Stuefe]

On Mon, 29 Jan 2024 01:59:17 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Sonia Zaldana Calles has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Implementation of high level debug logging and low level trace logging
>>  - Implementation of high level debug logging
>>  - Feedback - deleting oracle copyright and fixing INTPTR formatting
>
> src/hotspot/share/utilities/preserveErrno.hpp line 1:
> 
>> 1: #include <errno.h>
> 
> This file requires an OpenJDK copyright and licence header.
> 
> But do we really need a a file just for this? I think it could be added to os.hpp

os.hpp gets pretty hefty though. This gives us better granularity.

Moreover, we have a sister structure (PreserveLastError or somesuch) we use on Windows for the same purpose, we could put them together in this file.

> src/hotspot/share/utilities/preserveErrno.hpp line 4:
> 
>> 2: 
>> 3: 
>> 4: // Preserve errno across a range of calls
> 
> You also need to expose the preserved value so it can be logged.

+1

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1470951689
PR Review Comment: https://git.openjdk.org/jdk/pull/17356#discussion_r1470948929