RFR: 8324838: test_nmt_locationprinting.cpp broken in the gcc windows build

Kevin Walls kevinw at openjdk.org
Tue Jan 30 11:29:41 UTC 2024


On Mon, 29 Jan 2024 12:52:11 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> test_nmt_locationprinting.cpp defines method test_for_dead_c_heap_block unconditionally, but this method is only ever used on Linux. In the gcc windows build this fires an unused method warning and breaks the gtest suite. Since this is never used outside of Linux, make this method's definition only appear on Linux to avoid polluting code on other platforms

Marked as reviewed by kevinw (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17612#pullrequestreview-1850946124


More information about the hotspot-runtime-dev mailing list