RFR: 8324838: test_nmt_locationprinting.cpp broken in the gcc windows build [v2]

Julian Waters jwaters at openjdk.org
Wed Jan 31 10:15:06 UTC 2024


> test_nmt_locationprinting.cpp defines method test_for_dead_c_heap_block unconditionally, but this method is only ever used on Linux. In the gcc windows build this fires an unused method warning and breaks the gtest suite. Since this is never used outside of Linux, make this method's definition only appear on Linux to avoid polluting code on other platforms

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  Copyright test_nmt_locationprinting.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17612/files
  - new: https://git.openjdk.org/jdk/pull/17612/files/d065aa13..664aff2f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17612&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17612&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17612.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17612/head:pull/17612

PR: https://git.openjdk.org/jdk/pull/17612


More information about the hotspot-runtime-dev mailing list